refactor(react): revert rollup ESM and CJS entrypoints #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit b7c4b7f https://deploy-preview-5444--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit b7c4b7f |
|
Deploy preview for carbon-components-react ready! Built with commit 0102c2e https://deploy-preview-5444--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 0102c2e |
asudoh
approved these changes
Feb 26, 2020
tw15egan
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts our rollup changes that generated an entrypoint for ESM and CJS. The issues are documented over in: #5442
Changelog
New
Changed
rollup.config.jsno longer outputs ESM and CJS entrypointsRemoved
Testing / Reviewing
reactes/index.jsandlib/index.jsno longer are flat bundles and instead export components from relative paths