-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(project): update Node.js version to v12 LTS #5391
Conversation
Deploy preview for carbon-elements ready! Built with commit fa7e12c |
Deploy preview for carbon-components-react ready! Built with commit fa7e12c https://deploy-preview-5391--carbon-components-react.netlify.com |
Yeesh, no idea what's going on with node-sass. If you end up needing to force one version that's totally fair, can place it in |
@joshblack yeah not sure :/ it looks like we have a node-sass@3 in our yarn lock and offline mirrors for some reason not sure if it’s trying to build that? |
@vpicone when looking at the error messages locally it seems like Can always try pinning it to the version we want to use too to see if that helps address it. |
@joshblack ah nice that was it. Updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing any issues after updating 👍 ✅
Motivation
Node 12 is the LTS version, we'll need to update eventually. This brings us in line with the theme/website minimum node versions as well.
Changelog
scss-to-json
v2 which removes its dependency onnode-sass
v3 which isnode 12
incompatible.