FIX: 32/settings--adjust.svg new geometry #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjustments to 32/settings--adjust to improve scaling and eliminate the need for bespoke sizes
removes 16/settings--adjust.svg
chrisconnors-ibm
requested review from
laurenmrice and
a team
as code owners
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 0fc3fc9 |
|
Deploy preview for carbon-components-react ready! Built with commit 0fc3fc9 https://deploy-preview-5361--carbon-components-react.netlify.com |
laurenmrice
approved these changes
Feb 17, 2020
chrisconnors-ibm
changed the title
… into settings--adjust-new-geometry
joshblack
approved these changes
Feb 17, 2020
dakahn
approved these changes
Feb 17, 2020
|
Note to merge, I think we'll need the commit to match: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments to geometry of 32/settings--adjust.svg to improve quality of scaled assets and eliminate the need for 16/settings--adjust.svg
Changelog
Changed
Removed
Testing / Reviewing
Consider
https://deploy-preview-5361--carbon-elements.netlify.com/icons/examples/preview/#32%2Fsettings--adjust
https://deploy-preview-5361--carbon-elements.netlify.com/icons/examples/preview/#32%2Fsettings--adjust%20(Downsized%20to%2024)
https://deploy-preview-5361--carbon-elements.netlify.com/icons/examples/preview/#32%2Fsettings--adjust%20(Downsized%20to%2020)
https://deploy-preview-5361--carbon-elements.netlify.com/icons/examples/preview/#32%2Fsettings--adjust%20(Downsized%20to%2016)
on @2x and @1x displays.
Will require re-generation of Sketch Icon Libraries.