-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: icons-new-january-february #5342
feat: icons-new-january-february #5342
Conversation
Submitting new and updated UI icons from January + February all updates and additions approved by BXD
Deploy preview for carbon-components-react ready! Built with commit f15153a https://deploy-preview-5342--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit f15153a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, will make sure to help scaffold out metadata either tomorrow or early next week!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @laurenmrice I originally made it as you specified above but then @jeanservaas slacked me a few days later and mentioned her and Mike decided there should be a space between fill and outer stroke. |
Thanks for clarifying Conrad! Just spoke with jeannie, are you using a 3px gap between the border and the fill? They want a 2px gap, so just wanted to confirm that. |
ya we originally agreed on 3px, seems like that's too close to radio button so 2px it is. Will update the icon and the PR in a mo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great ! thanks for making that fix ! 🚀
|
Submitting new and updated UI icons from January + February
all updates and additions approved by BXD
36 net new icons
1 removed icon (approved by Brand + Legal team, see Carbon issue: #5153)
updated categories.yml with additions and updates
updated ui-icon-master.ai with additions and updates
Changelog
New
Removed