chore(react): update storybook to re-enable theming panels #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements failed. Built with commit 6d7396d https://app.netlify.com/sites/carbon-elements/deploys/5e45696301db2f00087d69bb |
|
Deploy preview for carbon-components-react ready! Built with commit 6d7396d https://deploy-preview-5332--carbon-components-react.netlify.com |
|
cc @aagonzales if you wanted to double-check! |
aagonzales
reviewed
Feb 12, 2020
aagonzales
approved these changes
Feb 12, 2020
aledavila
approved these changes
Feb 12, 2020
asudoh
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5331
Update storybook config to remove dynamic import and update call signature for addons registration.
Changelog
New
Changed
Removed
Testing / Reviewing
yarn storybookdoes not include the theme and type panelsCARBON_REACT_STORYBOOK_USE_CUSTOM_PROPERTIES=true yarn storybookdoes include the theme and type panels