Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): ensure tooltip is not hidden in storybook #5304

Merged
merged 8 commits into from
Feb 10, 2020
Merged

fix(tooltip): ensure tooltip is not hidden in storybook #5304

merged 8 commits into from
Feb 10, 2020

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Feb 7, 2020 •
edited
Loading

Closes #5286

Centers Tooltip so that the pop up is not hidden under the side nav

Also adjusts Tooltip positioning logic for left and right directions

Changelog

New

  • Storybook specific position styles

Changed

  • Modified positioning for left and right variations

Testing / Reviewing

Ensure the tooltip no longer renders under the side nav

@tw15egan tw15egan requested a review from a team as a code owner February 7, 2020 19:18
@ghost ghost requested review from abbeyhrt and dakahn February 7, 2020 19:18
@tw15egan tw15egan requested a review from laurenmrice February 7, 2020 19:19
@tw15egan tw15egan force-pushed the storybook-tooltip-fix branch from 0b9cd62 to b2b66ce Compare February 7, 2020 19:22
@netlify
Copy link

netlify bot commented Feb 7, 2020

Deploy preview for carbon-elements ready!

Built with commit 0b9cd62

https://deploy-preview-5304--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 7, 2020

Deploy preview for carbon-components-react failed.

Built with commit 0b9cd62

https://app.netlify.com/sites/carbon-components-react/deploys/5e3db811b547f800087565e2

laurenmrice
laurenmrice requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the icon be the info icon again with icon-02 color token? Right now its showing a red dot

The tooltip open looks good when set to bottom and right now. It still gets covered up for left and top`. I don't know if its that big of a deal for people if some positioning options look visually cut off, but it looks weird to me.

@netlify
Copy link

netlify bot commented Feb 7, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit e190028

https://deploy-preview-5304--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 7, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit e190028

https://app.netlify.com/sites/carbon-components-react/deploys/5e41a9134e92d700086c8c5f

@tw15egan
Copy link
Collaborator Author

tw15egan commented Feb 7, 2020

@laurenmrice updated

laurenmrice
laurenmrice requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

One last thing, the tooltip shark fins just needs to point to the center of the icon in the left and right positions. The others look good.
Screen Shot 2020-02-07 at 3 39 50 PM

@tw15egan tw15egan force-pushed the storybook-tooltip-fix branch from b44be1d to 0df89bf Compare February 7, 2020 22:00
@tw15egan
Copy link
Collaborator Author

tw15egan commented Feb 7, 2020

@laurenmrice updated again!

@tw15egan tw15egan changed the title docs(tooltip): ensure tooltip is not hidden in storybook fix(tooltip): ensure tooltip is not hidden in storybook Feb 7, 2020
laurenmrice
laurenmrice approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you !! 🙌🏻

@tw15egan tw15egan merged commit b8c1e1c into carbon-design-system:master Feb 10, 2020
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@lee-chase lee-chase mentioned this pull request Dec 1, 2020
Merged
@tw15egan tw15egan deleted the storybook-tooltip-fix branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tooltip] interactive tooltip when open goes off page in react
4 participants
@tw15egan @abbeyhrt @dakahn @laurenmrice