docs: move Multiselect.Filterable from knobs to it's own story #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 0868a98 |
tw15egan
approved these changes
Feb 6, 2020
|
Deploy preview for carbon-components-react failed. Built with commit 0868a98 https://app.netlify.com/sites/carbon-components-react/deploys/5e3c9e208fbcd20008610e04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5293
Considering
Multiselect.Filterableis essentially it's own component, it should be surfaced as it's own story rather than hidden amongst thepropsobject that gets used to generate knobs.Accessing a component via dot notation/destructuring is a pretty rare occurence in our library. It's unclear to me why this behavior wasn't just exposed via a prop.
This also allows us to provide specific guidance in the story for when someone might use this component and makes all of the
storytabs more legibile rather than showingComponentToUse.Changelog
New
filterablestory for multiselectRemoved
Testing / Reviewing
Use the new story