Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devenv): deploy vanilla devenv #5227

Merged
merged 6 commits into from
Feb 1, 2020
Merged

chore(devenv): deploy vanilla devenv #5227

merged 6 commits into from
Feb 1, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 31, 2020 •
edited
Loading

Fixes #5205.

Changelog

New

  • A new CF route to vanilla development environment.
  • A GitHub Actions logic to push vanilla development environment to CF upon new commits.

@asudoh asudoh requested a review from a team as a code owner January 31, 2020 08:06
@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit a4d6f52

https://deploy-preview-5227--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit a4d6f52

https://app.netlify.com/sites/carbon-elements/deploys/5e34c15391008800071cfc06

@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit a4d6f52

https://deploy-preview-5227--carbon-components-react.netlify.com

@asudoh asudoh changed the title hore(devenv): deploy vanilla devenv chore(devenv): deploy vanilla devenv Jan 31, 2020
emyarod
emyarod approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just one note

.github/workflows/deploy-vanilla-devenv.yml Outdated Show resolved Hide resolved
joshblack
joshblack approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had the same note as @emyarod 👍

@asudoh asudoh merged commit c9019ce into carbon-design-system:master Feb 1, 2020
@asudoh asudoh deleted the deploy-vanilla-devenv branch February 1, 2020 00:25
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Point vanilla demo environment to vanilla.carbondesignsystem.com
4 participants
@asudoh @joshblack @emyarod @abbeyhrt