-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inline-loading): update type token #5172
fix(inline-loading): update type token #5172
Conversation
From `body-short-01` to `label-01`. Fixes carbon-design-system#5165.
Deploy preview for the-carbon-components ready! Built with commit 15cf93e https://deploy-preview-5172--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 15cf93e |
Deploy preview for carbon-components-react ready! Built with commit 15cf93e https://deploy-preview-5172--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me pending design review
I am unable to review this pr on react locally, but I have been able to it with other prs today. Do you know why this may be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed with akira via slack with screenshots. lgtm 👍🏻
From
body-short-01
tolabel-01
.Fixes #5165.
Changelog
Changed
body-short-01
tolabel-01
.Testing / Reviewing
Testing should make sure inline loading is not broken.