Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inline-loading): update type token #5172

Merged
merged 2 commits into from
Jan 27, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 24, 2020

From body-short-01 to label-01.

Fixes #5165.

Changelog

Changed

  • Type style of inline loading text from body-short-01 to label-01.

Testing / Reviewing

Testing should make sure inline loading is not broken.

From `body-short-01` to `label-01`.
Fixes carbon-design-system#5165.
@netlify
Copy link

netlify bot commented Jan 24, 2020

Deploy preview for the-carbon-components ready!

Built with commit 15cf93e

https://deploy-preview-5172--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 24, 2020

Deploy preview for carbon-elements ready!

Built with commit 15cf93e

https://deploy-preview-5172--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 24, 2020

Deploy preview for carbon-components-react ready!

Built with commit 15cf93e

https://deploy-preview-5172--carbon-components-react.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending design review

@laurenmrice
Copy link
Member

I am unable to review this pr on react locally, but I have been able to it with other prs today. Do you know why this may be?

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed with akira via slack with screenshots. lgtm 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inline loading] need to be using label-01 type style
4 participants