Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): remove margin added by safari #5169

Merged
merged 6 commits into from
Jan 29, 2020
Merged

fix(button): remove margin added by safari #5169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e90f22
fix(button): remove margin added by safari
tw15egan Jan 24, 2020
2ce0f51
Merge branch 'master' into remove-safari-button-margin
tw15egan Jan 24, 2020
4001b03
Merge branch 'master' into remove-safari-button-margin
tw15egan Jan 28, 2020
bd5dfc0
Merge branch 'master' into remove-safari-button-margin
tw15egan Jan 28, 2020
d1c0061
fix(button): add button fix to reset file as well
tw15egan Jan 28, 2020
b0fdec3
fix(button): make margin reset less browser specific
tw15egan Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/src/components/button/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
outline: none;
position: relative;
max-width: rem(320px);
// Fix to remove added margins on buttons in safari (see #5155)
margin: 0;

&:disabled,
&.#{$prefix}--btn--disabled {
Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/globals/scss/_css--reset.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@
box-sizing: border-box;
}

// Fix to remove added margins on buttons in safari (see #5155)
button {
margin: 0;
}

@include carbon--type-reset;
@include carbon--icons;
}
Expand Down