Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list-box): fix dropdown item sizes #5128

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 22, 2020

Fixes #5070.

Changelog

Changed

  • Changes to keep list box/dropdown item sizes in sync with the trigger button.

Testing / Reviewing

Testing should make sure dropdown, combo box and multi select are not broken.

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for the-carbon-components ready!

Built with commit 50100d6

https://deploy-preview-5128--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-elements ready!

Built with commit 50100d6

https://deploy-preview-5128--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-components-react failed.

Built with commit 50100d6

https://app.netlify.com/sites/carbon-components-react/deploys/5e28b6baccf8fb000a462985

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, pending visual review

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me ! thanks ! 👍🏻

@tw15egan tw15egan merged commit 2975d56 into carbon-design-system:master Jan 22, 2020
@asudoh asudoh deleted the list-box-item-sizes branch January 22, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dropdown] size variants need to have same size drawer items
6 participants