Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-picker): use correct background for date picker in modal #5123

Merged
merged 2 commits into from
Jan 21, 2020
Merged

fix(date-picker): use correct background for date picker in modal #5123

merged 2 commits into from
Jan 21, 2020

Conversation

tw15egan
Copy link
Collaborator

Closes #5121

Adds DatePicker to the list of form items that should have inverse backgrounds when placed inside of a modal.

Changelog

New

  • .#{$prefix}--date-picker__input added to list of modal overrides

Testing / Reviewing

Add a DatePicker to a Modal example and ensure it does not blend with the background

Screen Shot 2020-01-21 at 11 30 28 AM

@tw15egan tw15egan requested a review from a team as a code owner January 21, 2020 19:31
@ghost ghost requested review from aledavila and emyarod January 21, 2020 19:31
@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for the-carbon-components ready!

Built with commit b33911d

https://deploy-preview-5123--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-components-react failed.

Built with commit b33911d

https://app.netlify.com/sites/carbon-components-react/deploys/5e2751912f60f20009b93d38

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-elements failed.

Built with commit b33911d

https://app.netlify.com/sites/carbon-elements/deploys/5e275191e83c900008ff06af

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for the-carbon-components ready!

Built with commit aa22c7a

https://deploy-preview-5123--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-elements ready!

Built with commit aa22c7a

https://deploy-preview-5123--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-components-react failed.

Built with commit aa22c7a

https://app.netlify.com/sites/carbon-components-react/deploys/5e2751cd73910b000e73b532

@tw15egan tw15egan merged commit 7bdf57f into carbon-design-system:master Jan 21, 2020
@tw15egan tw15egan deleted the date-picker-bg-modal branch January 21, 2020 22:55
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@tw15egan @joshblack
fix(date-picker): use correct background for date picker in modal (ca…
08b6d3c 
…rbon-design-system#5123)
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@joshblack joshblack joshblack approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date picker background is wrong within modals
3 participants
@tw15egan @joshblack @aledavila