Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint and stylelint dependencies #5098

Merged

Conversation

joshblack
Copy link
Contributor

Update eslint and stylelint dependencies. Also includes fixes for lint violations.

Changelog

New

Changed

  • Update stylelint to 13.0.0
  • Update eslint to 8.6.0
  • Update files to address violations

Removed

@joshblack joshblack requested a review from a team as a code owner January 17, 2020 23:41
@ghost ghost requested review from asudoh and emyarod January 17, 2020 23:41
@netlify
Copy link

netlify bot commented Jan 17, 2020

Deploy preview for the-carbon-components ready!

Built with commit 1bf33e8

https://deploy-preview-5098--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 17, 2020

Deploy preview for carbon-elements ready!

Built with commit 1bf33e8

https://deploy-preview-5098--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 17, 2020

Deploy preview for carbon-components-react ready!

Built with commit 1bf33e8

https://deploy-preview-5098--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 18, 2020

Deploy preview for carbon-components-react failed.

Built with commit b524b93

https://app.netlify.com/sites/carbon-components-react/deploys/5e26061ef48f5b000921d227

@netlify
Copy link

netlify bot commented Jan 18, 2020

Deploy preview for the-carbon-components ready!

Built with commit b524b93

https://deploy-preview-5098--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 18, 2020

Deploy preview for carbon-elements ready!

Built with commit b524b93

https://deploy-preview-5098--carbon-elements.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@tw15egan tw15egan merged commit 68f3dfd into carbon-design-system:master Jan 20, 2020
@joshblack joshblack deleted the chore/update-lint-dependencies branch January 20, 2020 20:44
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
* chore(project): update eslint to 8.6.0

* chore(project): update stylelint to 13.0.0

* chore(project): fix eslint and stylelint violations

* chore(project): sync offline mirror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants