Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(token): add new $text-error #5056

Merged
merged 13 commits into from
Jan 16, 2020
Merged

feat(token): add new $text-error #5056

merged 13 commits into from
Jan 16, 2020

Conversation

aagonzales
Copy link
Member

Related: #5024

  • Added new $text-error token
  • Updated value of $support-01 in the G90 theme.

@aagonzales aagonzales requested a review from a team as a code owner January 15, 2020 20:11
joshblack
joshblack suggested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! Left some comments for some import issues we might run into

packages/themes/src/g100.js Show resolved Hide resolved
packages/themes/src/g90.js Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit d151c0c

https://deploy-preview-5056--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020

Deploy preview for carbon-components-react failed.

Built with commit 05732af

https://app.netlify.com/sites/carbon-components-react/deploys/5e1f722f5b19ce000ba6da2a

@netlify
Copy link

netlify bot commented Jan 15, 2020

Deploy preview for the-carbon-components failed.

Built with commit 05732af

https://app.netlify.com/sites/the-carbon-components/deploys/5e1f722f3d7650000878d1f4

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit d151c0c

https://app.netlify.com/sites/carbon-components-react/deploys/5e20dbc67e5ff70008b28966

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit d151c0c

https://deploy-preview-5056--the-carbon-components.netlify.com

@tw15egan
Copy link
Collaborator

Does the new variable also have to be added towards the bottom of tokens.js?

carbon/packages/themes/src/tokens.js

Line 177 in 4cae6f2

'text05',

Not quite sure what the unstable__meta is used for

@joshblack
Copy link
Contributor

@tw15egan good catch, unstable__meta is for the Sketch plugin so that the colors are placed in the correct grouping 👍

tw15egan
tw15egan approved these changes Jan 16, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these in, Anna! 👍 💪

@asudoh
Copy link
Contributor

asudoh commented Jan 16, 2020

@joshblack Just in case you have any further comments - Thanks!

asudoh
asudoh approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @aagonzales!

@asudoh asudoh merged commit fb349c6 into carbon-design-system:master Jan 16, 2020
@aagonzales aagonzales deleted the token-updates branch January 16, 2020 22:16
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@RoystonS
Copy link

RoystonS commented Feb 4, 2020

Will you also be updating the metadata.yml file to reflect these changes?

This was referenced Feb 25, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aagonzales @tw15egan @joshblack @asudoh @RoystonS