-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: icons-new-december #5015
feat: icons-new-december #5015
Conversation
Submitting new and updated UI icons from December
Submitting new and updated UI icons from December
Deploy preview for the-carbon-components ready! Built with commit 97fca4c https://deploy-preview-5015--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 97fca4c |
Deploy preview for the-carbon-components ready! Built with commit e4b8329 https://deploy-preview-5015--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit e4b8329 https://deploy-preview-5015--carbon-components-react.netlify.com |
Deploy preview for carbon-elements failed. Built with commit e4b8329 https://app.netlify.com/sites/carbon-elements/deploys/5e2207d9894853000803e1f2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me ! love the new additions 🎉
Hey @conradennis! Seems like we have the following issue coming up:
Were these part of the renames/changes that you were talking about? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For icons that are removed/renamed, I think we'll need to keep the originals in codebase as the removal will be a breaking change 😞 For ones that we want to remove, we should flag them as deprecated so folks know not to use them and that they'll be removed.
@joshblack only 4 icons were removed/renamed. not sure why the whole set of icons is causing a problem. The renamed icons are the original files, it's just that github recognizes them as removed when they're renamed, so should we add those four back into the repo under their old names? |
Submitting new and updated UI icons from December
all updates and additions approved by BXD
47 net new icons
5 updated icons
4 renamed/removed icons
updated categories.yml with additions and updates
updated ui-icon-master.ai with additions and updates
note that
lightning
moon
sun
are all duplicates of existing icons that have been renamed and added to theplanning > weather
categoryChangelog
New
Changed
Removed