refactor(CopyButton): inherit Copy component #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit c90d77e https://deploy-preview-5006--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit c90d77e https://deploy-preview-5006--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements failed. Built with commit c90d77e https://app.netlify.com/sites/carbon-elements/deploys/5e1ca37f2856660008cfb156 |
joshblack
approved these changes
Jan 10, 2020
dakahn
approved these changes
Jan 10, 2020
asudoh
requested review from
a team and
aagonzales
and removed request for
a team
aagonzales
approved these changes
Jan 13, 2020
emyarod
force-pushed
the
5005-copybutton-inherit-copy
branch
from
01f356e to
24b2b66
Compare
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
* refactor(CopyButton): inherit Copy component * refactor(code-snippet): unnest rules * test(CopyButton): full mount for button props test * docs(CodeSnippet): change default story feedback text
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5005
this PR refactors the
<CopyButton>to directly inherit<Copy>. neither component is exported but the component only differs in that<Copy>appears to only be used in inline code snippets, and<CopyButton>is used for the other code snippet variants. since the behavior is identical it can all be contained in<Copy>Changelog
Changed
Testing / Reviewing
Ensure the CopyButton and code snippet variants function as expected