Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ComboBox): ensure unique keys #4999

Merged
merged 6 commits into from
Jan 11, 2020
Merged

fix(ComboBox): ensure unique keys #4999

merged 6 commits into from
Jan 11, 2020

Commits on Jan 10, 2020

  1. fix(ComboBox): ensure unique keys 

    This change swiches React `key`s of the items of `<Dropdown>` as well
as the one of `<ComboBox>` from their text content to provided keys in
data.

This is applying the corresponding logic of `<MultiSelect>`.
In this way duplicate item text won't yeild duplicate React keys.

Fixes carbon-design-system#4969.
    @asudoh
    asudoh committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    32608a8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into listbox-key

    @joshblack
    joshblack authored Jan 10, 2020
    Configuration menu
    Copy the full SHA
    75d02c4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into listbox-key

    @joshblack
    joshblack authored Jan 10, 2020
    Configuration menu
    Copy the full SHA
    4ac1c21 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Merge branch 'master' into listbox-key

    @asudoh
    asudoh authored Jan 11, 2020
    Configuration menu
    Copy the full SHA
    0dfb738 View commit details
    Browse the repository at this point in the history

  2. test(Dropdown): update snapshot

    @asudoh
    asudoh committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    ffbbac1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into listbox-key

    @asudoh
    asudoh authored Jan 11, 2020
    Configuration menu
    Copy the full SHA
    0a657cd View commit details
    Browse the repository at this point in the history