-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(condensed-grid): moved vertical spacing to col #4960
Conversation
Deploy preview for carbon-components-react ready! Built with commit 7145b82 https://deploy-preview-4960--carbon-components-react.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit 7145b82 https://deploy-preview-4960--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 7145b82 |
@jendowns curious what you think about this if you have a sec! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after talking to josh, this seems like we're just changing how we set the space for the but the effect should be the same. Looks ok to me.
82be94d
to
e604a95
Compare
e604a95
to
7206e40
Compare
* fix(condensed-grid): moved vertical spacing to col * chore(grid): updating snapshot Co-authored-by: Alessandra Davila <[email protected]> Co-authored-by: Josh Black <[email protected]>
* fix(condensed-grid): moved vertical spacing to col * chore(grid): updating snapshot Co-authored-by: Alessandra Davila <[email protected]> Co-authored-by: Josh Black <[email protected]>
Continuation of #4577