Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #4955

Merged
merged 7 commits into from
Jan 7, 2020
Merged

Update CODEOWNERS #4955

merged 7 commits into from
Jan 7, 2020

Conversation

joshblack
Copy link
Contributor

Adds @conradennis as a CODEOWNER for icon assets

Changelog

New

Changed

Removed

@joshblack joshblack requested a review from a team January 6, 2020 16:28
@joshblack joshblack requested a review from a team as a code owner January 6, 2020 16:28
@ghost ghost requested review from aledavila, asudoh and laurenmrice and removed request for a team January 6, 2020 16:28
@netlify
Copy link

netlify bot commented Jan 6, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit c2b8490

https://app.netlify.com/sites/carbon-components-react/deploys/5e14cbe9f1d9650007cc9314

@netlify
Copy link

netlify bot commented Jan 6, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit c2b8490

https://deploy-preview-4955--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 6, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit c2b8490

https://deploy-preview-4955--the-carbon-components.netlify.com

@mjabbink
Copy link

mjabbink commented Jan 6, 2020

the preview link looks like this? Chrome and Safari. They are both showing up really narrow and one with big chevrons.

Screen Shot 2020-01-06 at 1 20 07 PM

Screen Shot 2020-01-06 at 1 20 10 PM

@joshblack
Copy link
Contributor Author

@mjabbink might depend on the preview link, the one for #4955 (comment) is the vanilla environment where the big arrows are the legacy icons if I remember correctly. Definitely isn't something we're shipping or putting on the site and is meant as a staging env for the team only 👍

@joshblack joshblack merged commit 11a3c41 into master Jan 7, 2020
@joshblack joshblack deleted the joshblack-patch-1 branch January 7, 2020 21:44
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 13, 2020
@joshblack
chore(project): update CODEOWNERS (carbon-design-system#4955)
85dc01d 
* Update CODEOWNERS

* Update CODEOWNERS
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 14, 2020
@joshblack
chore(project): update CODEOWNERS (carbon-design-system#4955)
cd1dc05 
* Update CODEOWNERS

* Update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@aledavila aledavila aledavila approved these changes

@mattrosno mattrosno mattrosno approved these changes

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joshblack @mjabbink @mattrosno @aledavila @abbeyhrt @laurenmrice