Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ComboBox): bring IME support back #4952

Merged
merged 4 commits into from
Jan 8, 2020
Merged

fix(ComboBox): bring IME support back #4952

merged 4 commits into from
Jan 8, 2020

Commits on Jan 6, 2020

  1. fix(ComboBox): bring IME support back 

    This change backs out carbon-design-system#3646 partially given moving `inputValue` state
syncing code from `handleOnInputValueChange` to `handleOnStateChange`
causes in-composition string (of IME) getting lost, because the
different rendering sequence yielded by such change causes Downshift to
(temporarily) render an older (stale) value to the `<input>`.

Fixes carbon-design-system#4947.
    @asudoh
    asudoh committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    df2513a View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Merge branch 'master' into combobox-ime

    @joshblack
    joshblack authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    1e707bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into combobox-ime

    @asudoh
    asudoh authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    f4fcb07 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into combobox-ime

    @asudoh
    asudoh authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    5c8917f View commit details
    Browse the repository at this point in the history