Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix labeler action globs and add auto add package labels #4946

Merged
merged 3 commits into from
Jan 6, 2020

Conversation

mattrosno
Copy link
Member

@mattrosno mattrosno commented Jan 2, 2020

Fixes the GitHub action that labels every new PR with squad: system so we can consolidate ZenHub workspaces. Glob syntax from actions/labeler#28 (comment).

Adds package labels as well to get a better feel for "splash zone" for each PR - better see which packages are affected by the PR. New package labels will also allow us to run analysis for reporting in the future.

Update

The default action doesn't work when the PR originated from a fork, due to read-only permissions of the GH token. (See actions/labeler#12 (comment).) This new approach adds a cron job that runs every 5 minutes on the master branch to label open PRs based on file patterns: https://github.com/marketplace/actions/periodic-labeler

@mattrosno mattrosno requested a review from a team as a code owner January 2, 2020 18:44
@netlify
Copy link

netlify bot commented Jan 2, 2020

Deploy preview for carbon-components-react ready!

Built with commit 3f4251e

https://deploy-preview-4946--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 2, 2020

Deploy preview for the-carbon-components ready!

Built with commit 3f4251e

https://deploy-preview-4946--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 2, 2020

Deploy preview for carbon-elements ready!

Built with commit 3f4251e

https://deploy-preview-4946--carbon-elements.netlify.com

@ghost ghost requested review from asudoh and dakahn January 2, 2020 19:26
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @mattrosno! Wanted to see dry-runs on private repos done, while I imagine it's done already.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mattrosno mattrosno merged commit e47baa5 into carbon-design-system:master Jan 6, 2020
@mattrosno mattrosno deleted the fix-labeler branch January 6, 2020 16:22
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 6, 2020
…on-design-system#4946)

* chore: fix labeler action globs and add auto add package labels

* chore: make action label open PRs every 5 mins instead of on PR creation

Co-authored-by: Josh Black <josh@josh.black>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants