Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): add missing units to carbon--rem calls #4927

Merged
merged 1 commit into from
Dec 20, 2019
Merged

fix(type): add missing units to carbon--rem calls #4927

merged 1 commit into from
Dec 20, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Dec 19, 2019 •
edited
Loading

Closes #4926

This PR adds missing px units to carbon--rem usage within the expressive-heading-01 & expressive-heading-02 maps.

Changelog

Changed

  • add missing px units

@jendowns jendowns requested a review from a team as a code owner December 19, 2019 23:11
@ghost ghost requested review from asudoh and dakahn December 19, 2019 23:11
@jendowns
Copy link
Contributor Author

@asudoh Should I make these changes inside of the carbon-components vendor files as well -- if so, is there a command to do so? Or if not, is that an automated process? Thank you!

@netlify
Copy link

netlify bot commented Dec 19, 2019

Deploy preview for the-carbon-components ready!

Built with commit 9c77248

https://deploy-preview-4927--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 19, 2019

Deploy preview for carbon-elements ready!

Built with commit 9c77248

https://deploy-preview-4927--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 19, 2019

Deploy preview for carbon-components-react failed.

Built with commit 9c77248

https://app.netlify.com/sites/carbon-components-react/deploys/5dfc03b901c89a0008097c0f

@asudoh
Copy link
Contributor

asudoh commented Dec 20, 2019

@jendowns Thank you for asking - It's: https://github.com/carbon-design-system/carbon/blob/v10.7.0/packages/components/tools/copy-vendor-styles.sh

@jendowns jendowns mentioned this pull request Dec 20, 2019
Closed
@joshblack
Copy link
Contributor

@jendowns feel free to make the changes in the source and the build process will handle moving everything over!

@joshblack joshblack merged commit 7bb8413 into carbon-design-system:master Dec 20, 2019
@jendowns jendowns mentioned this pull request Dec 20, 2019
Merged
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 6, 2020
@jendowns @joshblack
fix(type): add units to carbon--rem usage for expressive-type maps (c…
76107aa 
…arbon-design-system#4927)
@joshblack joshblack mentioned this pull request Jan 6, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Type]: Incorrect values passed to carbon--rem cause errors in downstream Sass builds
4 participants
@jendowns @asudoh @joshblack @dakahn