Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): add elementType to 'as' property type check (#4893) #4895

Merged
merged 4 commits into from
Dec 17, 2019
Merged

fix(button): add elementType to 'as' property type check (#4893) #4895

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47a52dd
fix(button): add elementType to 'as' property type check (#4893)
Dec 17, 2019
59a236d
Merge branch 'master' into Fix_4893
t-soares Dec 17, 2019
6986aeb
Merge branch 'master' into Fix_4893
t-soares Dec 17, 2019
03f5e8d
Merge branch 'master' into Fix_4893
asudoh Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react/src/components/Button/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ Button.propTypes = {
* Specify how the button itself should be rendered.
* Make sure to apply all props to the root node and render children appropriately
*/
as: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
as: PropTypes.oneOfType([
PropTypes.func,
PropTypes.string,
PropTypes.elementType,
]),

/**
* Specify an optional className to be added to your Button
Expand Down