Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codeowners #4708

Merged
merged 3 commits into from
Nov 19, 2019
Merged

chore: update codeowners #4708

merged 3 commits into from
Nov 19, 2019

Conversation

alisonjoseph
Copy link
Member

Updates codeowners to reference developers-system team

@alisonjoseph alisonjoseph requested a review from a team as a code owner November 18, 2019 19:58
@ghost ghost requested review from asudoh and dakahn November 18, 2019 19:58
@alisonjoseph alisonjoseph requested review from a team and removed request for asudoh and dakahn November 18, 2019 19:58
@ghost ghost requested review from abbeyhrt and joshblack and removed request for a team November 18, 2019 19:58
@netlify
Copy link

netlify bot commented Nov 18, 2019

Deploy preview for the-carbon-components ready!

Built with commit 8b3e4c6

https://deploy-preview-4708--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 18, 2019

Deploy preview for carbon-elements ready!

Built with commit 8b3e4c6

https://deploy-preview-4708--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 18, 2019

Deploy preview for carbon-components-react ready!

Built with commit 8b3e4c6

https://deploy-preview-4708--carbon-components-react.netlify.com

@joshblack
Copy link
Contributor

@alisonjoseph would we want to structure it like:

Teams:

  • System
    • Developers
    • Designers
  • Website
    • Developers
    • Designers

@alisonjoseph
Copy link
Member Author

We would have to name it system-developers I think, I tried making a sub-team called developers and it just moved the main one underneath system. Lets wait and sync with design on how they plan on working within the squads first. (meeting w/ Anna/Jeanne tomorrow morning)

@joshblack
Copy link
Contributor

Ah, got it. Would it instead be this structure that would be valid?

  • System
    • System - Designers
    • System - Developers

@alisonjoseph
Copy link
Member Author

Yep 👍

@asudoh asudoh merged commit 0b4aeff into master Nov 19, 2019
@asudoh asudoh deleted the alisonjoseph-patch-codeowners branch November 19, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants