fix(Tag): added new prop titleText to specify title on clear

[ankitious]

Closes #4025

Changelog

New

• Added titleText prop to specify title text on clear button

Testing / Reviewing

• Go to Tab with filter
• Specify titleText prop as a string
• hover over clear button, text should be visible.

[netlify]

Deploy preview for the-carbon-components ready!

Built with commit f0af3c0

https://deploy-preview-4163--the-carbon-components.netlify.com

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit f0af3c0

https://deploy-preview-4163--carbon-components-react.netlify.com

[netlify]

Deploy preview for carbon-elements ready!

Built with commit f0af3c0

https://deploy-preview-4163--carbon-elements.netlify.com

[emyarod]

for the sake of consistency can we refactor this to follow the translateWithId pattern we have in the rest of the library?

for reference: https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/ListBox/ListBoxField.js

[asudoh]

@emyarod translateWithId is there only for limited set of components - So probably we can leave it as-is?

[joshblack]

Ignore me!

[joshblack]

Would we want to use the title prop directly for this? Wasn't sure if it's being used elsewhere in the component but would be fine to use it directly

[ankitious]

@joshblack title is not used anywhere else in component, so I have replaced titleText to title prop. Thanks!

[ankitious]

@joshblack I have changed props name to title, or do we want to follow translateWithId pattern suggested by @emyarod

Please provide your suggestion. Thanks!

[joshblack]

@ankitious should be good with title here, as I think it's analogous to how we expose labels for folks to customize 😄

[emyarod]

looks good to me, just one small nitpick

[joshblack]

cc @dakahn including you to double-check a11y on this if you have a sec, I think the component itself may already have an issue given that there is no button for the icon. If there are issues for this, and we're planning on addressing them in the a11y project, does the proposed solution here align with whatever the ideal is? Trying to think if we should be using aria-label here now, or not.

[dakahn]

This is fine. Being able to customize the title attribute doesn't really jam up anything we had planned. The aria seems to be adequate in so far as it's read properly by NVDA on Firefox.