Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): add danger, text05, update text02 #3962

Merged
merged 6 commits into from
Sep 12, 2019

Conversation

shixiedesign
Copy link
Contributor

@shixiedesign shixiedesign commented Sep 12, 2019

Closes #3960
Partially closes #3736

This PR adds $danger and $text05 token, and updates the values of $text02 token on light themes.

Changelog

New

  • $danger
  • $text-05 for tertiary text

Changed

  • $text-02 on light themes

Testing / Reviewing

Make sure Text input & Button-danger are seeing the updates. It should have the following color:

Text input - White theme Copy

@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for carbon-components-react ready!

Built with commit a45737b

https://deploy-preview-3962--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for carbon-elements ready!

Built with commit a45737b

https://deploy-preview-3962--carbon-elements.netlify.com

packages/themes/src/g10.js Outdated Show resolved Hide resolved
Co-Authored-By: Josh Black <[email protected]>
@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for the-carbon-components failed.

Built with commit 0f3564f

https://app.netlify.com/sites/the-carbon-components/deploys/5d79afd414ccf80009bf47e0

@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for the-carbon-components ready!

Built with commit a45737b

https://deploy-preview-3962--the-carbon-components.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 from the perspective of the code - Thanks @shixiedesign!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the new tokens going to be added to text input styles in this PR? for example I think the error icon is still using $support-01 and it can be changed to $danger now right?

@aagonzales
Copy link
Member

aagonzales commented Sep 12, 2019

We should talk when you get in the office. These are working differently that I thought. All parts of the error state should be using support-01. Why are they being mixed here? I thought the new token was for the danger buttons, I think realize it affected error states as well. I'm not sure if it worth having to different color reds on one error state, can they all just used the same color?

image

@shixiedesign
Copy link
Contributor Author

After talking to Anna, we agreed to keep button & icons to use $danger for better contrast, border and error text to use $support-01. I updated PR description accordingly. This is another review item for text input.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokens themselves are good to go! (got distracted by the image)

packages/themes/src/v9.js Outdated Show resolved Hide resolved
@shixiedesign
Copy link
Contributor Author

@emyarod No this PR only adds the tokens! Sorry I created the confusion with the image of text input. I didn't touch the components so the tokens are not applied. The actual components work will be separate issues and PRs.

@shixiedesign shixiedesign merged commit 36113ce into master Sep 12, 2019
@shixiedesign shixiedesign deleted the shixie-tokensUpdate branch September 12, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text05 tokens [Button] Support token & danger buttons fix
5 participants