-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens): add danger, text05, update text02 #3962
Conversation
Deploy preview for carbon-components-react ready! Built with commit a45737b https://deploy-preview-3962--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit a45737b |
Co-Authored-By: Josh Black <[email protected]>
Deploy preview for the-carbon-components failed. Built with commit 0f3564f https://app.netlify.com/sites/the-carbon-components/deploys/5d79afd414ccf80009bf47e0 |
Deploy preview for the-carbon-components ready! Built with commit a45737b https://deploy-preview-3962--the-carbon-components.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 from the perspective of the code - Thanks @shixiedesign!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the new tokens going to be added to text input styles in this PR? for example I think the error icon is still using $support-01
and it can be changed to $danger
now right?
We should talk when you get in the office. These are working differently that I thought. All parts of the error state should be using |
After talking to Anna, we agreed to keep button & icons to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tokens themselves are good to go! (got distracted by the image)
Co-Authored-By: Josh Black <[email protected]>
@emyarod No this PR only adds the tokens! Sorry I created the confusion with the image of text input. I didn't touch the components so the tokens are not applied. The actual components work will be separate issues and PRs. |
Closes #3960
Partially closes #3736
This PR adds
$danger
and$text05
token, and updates the values of$text02
token on light themes.Changelog
New
$danger
$text-05
for tertiary textChanged
$text-02
on light themesTesting / Reviewing
Make sure Text input & Button-danger are seeing the updates. It should have the following color: