Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): reduce icon tooltip SVG selector specificity #3649

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Aug 5, 2019

Closes #3602

Testing / Reviewing

Ensure all cases of icon tooltip usage is not broken (icon tooltip, password input, icon only button)

@netlify
Copy link

netlify bot commented Aug 5, 2019

Deploy preview for the-carbon-components ready!

Built with commit 62f9ee9

https://deploy-preview-3649--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 5, 2019

Deploy preview for carbon-components-react ready!

Built with commit 62f9ee9

https://deploy-preview-3649--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Aug 5, 2019

Deploy preview for carbon-elements ready!

Built with commit 62f9ee9

https://deploy-preview-3649--carbon-elements.netlify.com

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

@tw15egan tw15egan requested a review from a team August 5, 2019 17:56
@ghost ghost requested review from abbeyhrt and joshblack and removed request for a team August 5, 2019 17:57
@tw15egan tw15egan merged commit c43a59f into carbon-design-system:master Aug 5, 2019
@emyarod emyarod deleted the 3602-reduce-tooltip-icon-selector-specificity branch August 20, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to Change the color of TooltipIcon?
3 participants