fix(modal): replace width rule with padding #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 0913bf9 https://deploy-preview-3607--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 0913bf9 https://deploy-preview-3607--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 0913bf9 |
ghost
requested review from
|
Not that I disagree with this change but I'm curious, isn't this a breaking change for any user of Carbon 10 that has asked how to overwrite the 75% width setup for modal (i've seen it multiple times in slack and the issue backlog)? |
|
@elizabethsjudd I don't think it's likely, but let us know if you can think of any specific case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3412
This PR replaces the width rule on modal header and content with a padding change instead
Testing / Reviewing
Ensure the modal appears correct