Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): support different numbers of buttons #2900

Merged
merged 2 commits into from
Jun 3, 2019
Merged

fix(modal): support different numbers of buttons #2900

merged 2 commits into from
Jun 3, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented May 31, 2019

Fixes #2325.

Changelog

Changed

  • Replaced hard-coded 50% width of modal footer buttons to "equal divide" width.

Testing / Reviewing

Testing should make sure modal is not broken.

@asudoh asudoh requested a review from shixiedesign May 31, 2019 22:21
@netlify
Copy link

netlify bot commented May 31, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 0507856

https://deploy-preview-2900--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented May 31, 2019 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 0507856

https://app.netlify.com/sites/carbon-components-react/deploys/5cf536205ba83500073003c2

@asudoh
Copy link
Contributor Author

asudoh commented May 31, 2019

Can be tested by going to https://deploy-preview-2900--the-carbon-components.netlify.com/component/modal--default.html, select a footer button in DOM inspector, and delete (or edit the HTML of) the button.

emyarod
emyarod approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@netlify
Copy link

netlify bot commented Jun 3, 2019

Deploy preview for carbon-elements failed.

Built with commit 0507856

https://app.netlify.com/sites/carbon-elements/deploys/5cf53620a7b17c0007c50518

@joshblack joshblack merged commit c3672c8 into carbon-design-system:master Jun 3, 2019
@shixiedesign
Copy link
Contributor

I know this is already merged, but looks good! Thanks for the fix & instruction on how to review :)
image

@asudoh asudoh deleted the modal-buttons branch June 3, 2019 21:50
harpality pushed a commit to harpality/carbon that referenced this pull request Jun 5, 2019
@asudoh @harpality
fix(modal): support different numbers of buttons (carbon-design-syste…
9bf5bc5 
…m#2900)

Fixes carbon-design-system#2325.
joshblack pushed a commit that referenced this pull request Jun 12, 2019
@harpality @joshblack
fix(overflow-menu): update aria-label and roles, made ul a sibling (#…
2acc3e3 
…2906)

* fix(overflow-menu): updated aria-label and roles, made ul a sibling

* fix(overflow-menu): removing unused var

* fix(overflow-menu): update snapshots

* chore(project): use yarn policies to set version to 1.16.0 (#2902)

* chore(project): use yarn policies to set version to 1.16.0

* chore(project): update prettier to ignore .yarn folder

* fix(modal): support different numbers of buttons (#2900)

Fixes #2325.

* chore(examples): build examples based on whitelist (#2903)

* chore(release): v10.3.0-rc.2 (#2908)

* fix(overflow-menu): update defaultprops for Menu

* fix(overflow-menu): removed add'l this.props

* fix(overflow-menu): update snapshots

* fix(radio-button): group-level label/button alignment (#2914)

Fixes #2286.

* Fix sass error (#2905)

* chore(deps): bump sshpk in /packages/react/examples/create-react-app (#2915)

Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1.
- [Release notes](https://github.com/joyent/node-sshpk/releases)
- [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1)

* fix(overflow-menu): rollback ul changes

* fix(tooltip): set width to content max (#2923)

* chore(deps): bump safer-eval (#2930)

Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3.
- [Release notes](https://github.com/commenthol/safer-eval/releases)
- [Commits](commenthol/safer-eval@v1.2.3...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump safer-eval in /packages/colors/examples/preview (#2931)

Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3.
- [Release notes](https://github.com/commenthol/safer-eval/releases)
- [Commits](commenthol/safer-eval@v1.2.3...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* fix(button): require iconDescription for icon-only (#2929)

* fix(Button): require iconDescription for icon-only

Fixes #2884.

* chore(test): update snapshots

* fix(overflow-menu): update snapshots

* Revert "fix(overflow-menu): update snapshots"

This reverts commit 1015db6.

* fix(overflow-menu): update snapshots

* `Revert "fix(overflow-menu): update snapshots"

This reverts commit 6fe35a6.

* fix(overflow-menu): update snapshots

* chore(react): remove redundant version field
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jun 12, 2019
@harpality @joshblack
fix(overflow-menu): update aria-label and roles, made ul a sibling (c…
5cc00bb 
…arbon-design-system#2906)

* fix(overflow-menu): updated aria-label and roles, made ul a sibling

* fix(overflow-menu): removing unused var

* fix(overflow-menu): update snapshots

* chore(project): use yarn policies to set version to 1.16.0 (carbon-design-system#2902)

* chore(project): use yarn policies to set version to 1.16.0

* chore(project): update prettier to ignore .yarn folder

* fix(modal): support different numbers of buttons (carbon-design-system#2900)

Fixes carbon-design-system#2325.

* chore(examples): build examples based on whitelist (carbon-design-system#2903)

* chore(release): v10.3.0-rc.2 (carbon-design-system#2908)

* fix(overflow-menu): update defaultprops for Menu

* fix(overflow-menu): removed add'l this.props

* fix(overflow-menu): update snapshots

* fix(radio-button): group-level label/button alignment (carbon-design-system#2914)

Fixes carbon-design-system#2286.

* Fix sass error (carbon-design-system#2905)

* chore(deps): bump sshpk in /packages/react/examples/create-react-app (carbon-design-system#2915)

Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1.
- [Release notes](https://github.com/joyent/node-sshpk/releases)
- [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1)

* fix(overflow-menu): rollback ul changes

* fix(tooltip): set width to content max (carbon-design-system#2923)

* chore(deps): bump safer-eval (carbon-design-system#2930)

Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3.
- [Release notes](https://github.com/commenthol/safer-eval/releases)
- [Commits](commenthol/safer-eval@v1.2.3...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump safer-eval in /packages/colors/examples/preview (carbon-design-system#2931)

Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3.
- [Release notes](https://github.com/commenthol/safer-eval/releases)
- [Commits](commenthol/safer-eval@v1.2.3...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* fix(button): require iconDescription for icon-only (carbon-design-system#2929)

* fix(Button): require iconDescription for icon-only

Fixes carbon-design-system#2884.

* chore(test): update snapshots

* fix(overflow-menu): update snapshots

* Revert "fix(overflow-menu): update snapshots"

This reverts commit 1015db6.

* fix(overflow-menu): update snapshots

* `Revert "fix(overflow-menu): update snapshots"

This reverts commit 6fe35a6.

* fix(overflow-menu): update snapshots

* chore(react): remove redundant version field
emyarod pushed a commit to emyarod/carbon that referenced this pull request Jun 18, 2019
@harpality @emyarod
fix(overflow-menu): update aria-label and roles, made ul a sibling (c…
d515df5 
…arbon-design-system#2906)

* fix(overflow-menu): updated aria-label and roles, made ul a sibling

* fix(overflow-menu): removing unused var

* fix(overflow-menu): update snapshots

* chore(project): use yarn policies to set version to 1.16.0 (carbon-design-system#2902)

* chore(project): use yarn policies to set version to 1.16.0

* chore(project): update prettier to ignore .yarn folder

* fix(modal): support different numbers of buttons (carbon-design-system#2900)

Fixes carbon-design-system#2325.

* chore(examples): build examples based on whitelist (carbon-design-system#2903)

* chore(release): v10.3.0-rc.2 (carbon-design-system#2908)

* fix(overflow-menu): update defaultprops for Menu

* fix(overflow-menu): removed add'l this.props

* fix(overflow-menu): update snapshots

* fix(radio-button): group-level label/button alignment (carbon-design-system#2914)

Fixes carbon-design-system#2286.

* Fix sass error (carbon-design-system#2905)

* chore(deps): bump sshpk in /packages/react/examples/create-react-app (carbon-design-system#2915)

Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1.
- [Release notes](https://github.com/joyent/node-sshpk/releases)
- [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1)

* fix(overflow-menu): rollback ul changes

* fix(tooltip): set width to content max (carbon-design-system#2923)

* chore(deps): bump safer-eval (carbon-design-system#2930)

Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3.
- [Release notes](https://github.com/commenthol/safer-eval/releases)
- [Commits](commenthol/safer-eval@v1.2.3...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump safer-eval in /packages/colors/examples/preview (carbon-design-system#2931)

Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3.
- [Release notes](https://github.com/commenthol/safer-eval/releases)
- [Commits](commenthol/safer-eval@v1.2.3...v1.3.3)

Signed-off-by: dependabot[bot] <[email protected]>

* fix(button): require iconDescription for icon-only (carbon-design-system#2929)

* fix(Button): require iconDescription for icon-only

Fixes carbon-design-system#2884.

* chore(test): update snapshots

* fix(overflow-menu): update snapshots

* Revert "fix(overflow-menu): update snapshots"

This reverts commit 1015db6.

* fix(overflow-menu): update snapshots

* `Revert "fix(overflow-menu): update snapshots"

This reverts commit 6fe35a6.

* fix(overflow-menu): update snapshots

* chore(react): remove redundant version field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@emyarod emyarod emyarod approved these changes

@shixiedesign shixiedesign Awaiting requested review from shixiedesign

Assignees
No one assigned
Labels
status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Carbon X: Modal]: footer supports only 2 buttons
5 participants
@asudoh @shixiedesign @emyarod @dakahn @joshblack