Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shell): ui-shell header color updates #2721

Merged
merged 4 commits into from
May 14, 2019
Merged

feat(shell): ui-shell header color updates #2721

merged 4 commits into from
May 14, 2019

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented May 14, 2019

Closes#2704

Updates color tokens in shell theme - ONLY HEADER

Changelog

New

  • color tokens

Changed

  • separated panel tokens to their own

TODO:

  • Need to update variables in the .scss files for the side nav, panels, switcher (need to check they are using the correct variables) once designs are in
  • Need to update the hover variables hex color to variables names once that is in the elements package

@netlify
Copy link

netlify bot commented May 14, 2019

Deploy preview for the-carbon-components ready!

Built with commit 9771004

https://deploy-preview-2721--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented May 14, 2019

Deploy preview for carbon-components-react ready!

Built with commit 9771004

https://deploy-preview-2721--carbon-components-react.netlify.com

@joshblack
Copy link
Contributor

Hey @aledavila! I think prettier is just off which is causing the CI check to fail. Running this at the top-level should fix it:

yarn format

@tw15egan
Copy link
Collaborator

tw15egan commented May 14, 2019

Broke this issue apart into two separate issues, one that will track side nav variable updates and this one that contains header fixes.

Looks great!

👍

#2727 for reference

@tw15egan tw15egan merged commit 3a3f6ca into carbon-design-system:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color variables in UI Shell Header to IBM Color palette
5 participants