Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): move to monorepo #2363

Merged

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Apr 30, 2019

Closes #2382

Updates project to monorepo structure in preparation for merge with other codebases.

Reviewer checklist:

  • Lint staged works as expected
  • Editor plugins work as expected in nested package (like prettier)
  • Can still develop locally with fractal
  • GitHub files are up-to-date
  • CircleCI is running CI checks
  • ESLint works as expected
  • Tests run as expected, don't fail

@joshblack joshblack changed the title Refactor/move to monorepo refactor(project): move to monorepo Apr 30, 2019
@joshblack joshblack marked this pull request as ready for review April 30, 2019 20:23
@joshblack
Copy link
Contributor Author

joshblack commented Apr 30, 2019

TODO

  • Add root-level README.md file

@joshblack joshblack requested a review from a team April 30, 2019 22:05
@asudoh
Copy link
Contributor

asudoh commented May 1, 2019

Good checklist @joshblack, just one addition:

  • Build steps around Netlify deploy works

Seems that namedExports settings in our Rollup config need an update (Due to changed node_modules directory location)

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this Josh! tested developing, tests, linting and all seems to be working 🎉

@joshblack
Copy link
Contributor Author

joshblack commented May 1, 2019

@asudoh for netlify, I think what we'll need to do is use GitHub actions alongside Netlify to trigger deployments for specific sub-directories.

When looking at this earlier, it seemed like a combination of diff-includes and cli would handle our use-cases for publishing netlify builds for sub-packages that have changed

In the interim though, I can definitely set it up so that it hosts the right directory though 👍

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 from my perspective, would like feedback from others.

@joshblack joshblack mentioned this pull request May 2, 2019
8 tasks
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@asudoh asudoh merged commit 6b80872 into carbon-design-system:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize carbon-components as a monorepo
6 participants