Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): prevent bubbling on ESC on inactive #2344

Merged
merged 1 commit into from
Apr 24, 2019
Merged

fix(modal): prevent bubbling on ESC on inactive #2344

merged 1 commit into from
Apr 24, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Apr 23, 2019

Fixes #2312.

Changelog

Changed

  • A change to prevent event.stopPropagation() from running upon ESC key when modal is not open.

Testing / Reviewing

Testing should make sure our modal is not broken.

emyarod
emyarod approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

src/components/modal/modal.js Show resolved Hide resolved
@asudoh asudoh merged commit c7d8a3f into carbon-design-system:v9 Apr 24, 2019
@asudoh asudoh deleted the modal-esc-event-bubbling-v9 branch April 24, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @emyarod @jnm2377