fix: allow click on search magnifier to focus on input #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 9331699 https://deploy-preview-2321--the-carbon-components.netlify.com |
|
@lee-chase Thank you for this PR - Just wanted to let you know that we encourage people to enter issue along with PR except for internal chores. |
jnm2377
approved these changes
Apr 23, 2019
asudoh
approved these changes
Apr 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user I would expect that clicking the magnifier icon in the search input would place focus in the search box.
Changelog
Changed
Testing / Reviewing
Clicking the search magnifier should now place focus in the search input.