Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): fix redundant line introduced in recent commit #2165

Merged
merged 3 commits into from
Mar 21, 2019
Merged

chore(test): fix redundant line introduced in recent commit #2165

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80564fc
chore(test): fix redundant line introduced in recent commit
asudoh Mar 21, 2019
e61a531
fix(test): disable possibly stale shell test
asudoh Mar 21, 2019
c64718f
Merge branch 'master' into test-fix
jnm2377 Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const cloptions = commander
const isFilesDefault =
cloptions.file.length === defaultFiles.length && cloptions.file.every((item, i) => item === defaultFiles[i]);

cloptions.browser = ['Chrome'];
const customLaunchers = {
Chrome_Travis: {
base: 'Chrome',
Expand Down
4 changes: 3 additions & 1 deletion tests/spec/navigation-menu_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ describe('Popup Nav', function() {
expect(firstNavItem.focus).toHaveBeenCalledTimes(1);
});

it('should navigate into submenu', function() {
// eslint-disable-next-line no-undef
xit('should navigate into submenu', function() {
// TODO: We may have removed "down arrow to open" feature, go ahead and remove this test if so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it seems we removed this functionality from nav menus, but we can probably leave this test pending until more direction on UI shell navigation is provided

navigationMenuClass.changeNavSubmenuState({ matchesNavSubmenu: button, shouldBeCollapsed: false });
spyOn(firstNestedMenuItem, 'focus');
button.dispatchEvent(downArrowKeydown);
Expand Down