refactor(label): standardizing margin on bx--label #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 |
iangfleming
approved these changes
Apr 11, 2017
designertyler
pushed a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
chore: fix eslint, remove reach router dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize margin on form items
Most form elements were setting their own
margin-top, which was leading to inconsistency. Instead, moved the spacing tobx--label. All inputs should now get10pxspacing from the label, and items that require alegend(checkbox,radio) will receive an additional6px.Changed
bx--labelnow handles spacing between the label and the input.Removed
Closes https://github.ibm.com/Bluemix/carbon-issues/issues/83