-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Reset date range calendar when value is empty string or array #17889
base: main
Are you sure you want to change the base?
Fix: Reset date range calendar when value is empty string or array #17889
Conversation
Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 1 out of 2 committers have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like VS Code is adding .history
to the repo but we probably don't need to commit those files!
This reverts commit 983d219.
Hi @emyarod, Apologies, This is coming from a different commit that has been fixed and unrelated to this task. It looks good to me now. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @dedanade The Stackblitz does not work. |
Closes #17702
Fix issue when a user resets datepicker calendar using an empty string, array, or two empty strings in an array.
Changelog
New
Changed
Removed
Testing / Reviewing
Create a button to reset the date range in DatePicker.stories to reset the calendar with a daterange value like this https://stackblitz.com/edit/github-cmfaqv?file=src%2FApp.jsx.
Select the start and end date, click on the reset button you created above and reselect start date again to notice the end date doesn't automatically populate from the previous selection.