-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(flags): clarify enable-v12-dynamic-floating-styles not a sass flag #17887
docs(flags): clarify enable-v12-dynamic-floating-styles not a sass flag #17887
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there is still a snapshot update needed https://github.com/carbon-design-system/carbon/actions/runs/11523503750/job/32081668927?pr=17887
…into fix-floating-ui-flag
…x-floating-ui-flag
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17887 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 406 406
Lines 14046 14047 +1
Branches 4354 4355 +1
=======================================
+ Hits 11400 11401 +1
Misses 2480 2480
Partials 166 166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c300d45
Follow up to #17727
Changelog
New
Changed
Testing / Reviewing