Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(flags): clarify enable-v12-dynamic-floating-styles not a sass flag #17887

Merged

Conversation

tay1orjones
Copy link
Member

Follow up to #17727

Changelog

New

  • add enableV12DynamicFloatingStyles prop to FeatureFlag
  • add tests for each FeatureFlag prop

Changed

  • update storybook to clarify enable-v12-dynamic-floating-styles is a js-only flag, not a sass flag
  • add enableV12DynamicFloatingStyles to telemetry config
  • update snaps

Testing / Reviewing

  • New tests should pass, storybook docs should render properly

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit ea5d089
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6723bf77c2f69600088afa9a
😎 Deploy Preview https://deploy-preview-17887--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ea5d089
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6723bf770ee8ab00089c5b11
😎 Deploy Preview https://deploy-preview-17887--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ea5d089
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6723bf776815ef000851a020
😎 Deploy Preview https://deploy-preview-17887--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tay1orjones tay1orjones requested a review from a team as a code owner October 31, 2024 16:51
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (75c827d) to head (ea5d089).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17887   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         406      406           
  Lines       14046    14047    +1     
  Branches     4354     4355    +1     
=======================================
+ Hits        11400    11401    +1     
  Misses       2480     2480           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 31, 2024
Merged via the queue into carbon-design-system:main with commit c300d45 Oct 31, 2024
40 checks passed
@tay1orjones tay1orjones deleted the fix-floating-ui-flag branch October 31, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants