Increase code covergae for OverFlowMenuV2 #17884
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
soumyaraju
changed the title
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17884 +/- ##
==========================================
+ Coverage 80.35% 80.48% +0.13%
==========================================
Files 406 406
Lines 14041 14041
Branches 4395 4367 -28
==========================================
+ Hits 11282 11301 +19
+ Misses 2593 2574 -19
Partials 166 166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey thanks for taking a look at this! Rather than mocking the various components, these tests would be more valuable if they ensured the real code works as expected. Meaning if you render() something like what's shown/documented in storybook:
<OverflowMenuV2>
<CustomMenuItem />
<MenuItem label="Stop app" />
<MenuItemDivider />
<MenuItem label="Delete app" kind="danger" />
</OverflowMenuV2>
We'd want to assert that
console.warnis called as expected with the deprecation warninguseFeatureFlag('enable-v12-overflowmenu')returnstruefrom withinCustomMenuItem- Everything is passed through and spread onto the new implementation of OverflowMenu, meaning new OverflowMenu props such as
autoAlignare able to be set and have the proper result (auto align class is present) and the children MenuItem are rendered okay likeexpect(getByText('Stop app')).toBeInTheDocument();
This way the only thing you'll need to mock is the implementation of console.warn.
Closes #17507
Increase code coverage for overflowmenuv2