-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update to prettier 3.3.3, stylelint-prettier 5.0.2 #17799
fix(deps): update to prettier 3.3.3, stylelint-prettier 5.0.2 #17799
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I just pushed three commits here. The first updates our internal usages of prettier to use an We can remove this alias when one of a few things happens:
The second and third commit is the output of running |
…ylelint16-prettier3-eslint-plugin-prettier-5a_new
This comment was marked as off-topic.
This comment was marked as off-topic.
I think we should ignore coverage reports on this one. It's seeing tons of files as "changed" and therefore needing more tests, but they've just been reformatted. We'll hit those components through #16319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
…ylelint16-prettier3-eslint-plugin-prettier-5a_new
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Hey there! v11.69.0 was just released that references this issue/PR. |
…-design-system#17799) * ci: stylelint16_upgrade * fix: dedupe changes * fix: updates to stylelint16 * refactor: added old rules back * refactor: revert rules * fix: updates SCSS files & migrate to Stylelint 16.0.0 * refactor: null check * chore: yarn dedupe changes * refactor: refined package.json, updated rules object * refactor: cleaned comments & package.json * refactor: cleaned rules object * fix(deps): update stylelint16 & prettier3 * fix(deps): stylelint-prettier5 * fix(test): update test utils to use prettier v2 * chore: run yarn format w/ prettier 3 * chore: run yarn format with prettier 3 * chore: run yarn format * chore(deps): upgrade prettier to 3.3.3 * chore(prettier): format code * chore(prettier): format code --------- Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: Kenny Lam <[email protected]>
Closes #16604 #17406
A continuation of #17770, this updates prettier and stylelint-prettier.
The files changed are so large because this also includes all the related reformatting of the codebase based on the updated deps.
Changelog
Changed
🛑 This is a branch off #17770, this shouldn't be merged until that one is merged first.Merged! 👍