-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Increase coverage on FileUploaderDropContainer #17792
test: Increase coverage on FileUploaderDropContainer #17792
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17792 +/- ##
==========================================
+ Coverage 80.19% 80.35% +0.15%
==========================================
Files 406 406
Lines 14040 14040
Branches 4367 4347 -20
==========================================
+ Hits 11260 11282 +22
+ Misses 2613 2592 -21
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind filling out the body of the PR?
I'm only seeing around 60% coverage, we're looking for ideally 100%, but minimum 80%.
@alisonjoseph increased coverage upto 80%, can you re check now? |
@ariellalgilmore could you help me approve this PR and merge the changes. TIA |
114c71e
#17484
Increases coverage of FileUploaderDropContainer