Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase coverage on FileUploaderDropContainer #17792

Conversation

soumyaraju
Copy link
Contributor

@soumyaraju soumyaraju commented Oct 18, 2024

#17484

Increases coverage of FileUploaderDropContainer

@soumyaraju soumyaraju requested a review from a team as a code owner October 18, 2024 06:15
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit e508b4e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/671a253eace87200088f8c0b
😎 Deploy Preview https://deploy-preview-17792--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soumyaraju soumyaraju changed the title test: file uploader drop container test: Increase coverage on FileUploaderDropContainer Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e508b4e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671a253e4dc6a70008d2e7d7
😎 Deploy Preview https://deploy-preview-17792--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e508b4e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671a253e84ef5f00082ea061
😎 Deploy Preview https://deploy-preview-17792--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (a603f05) to head (e508b4e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17792      +/-   ##
==========================================
+ Coverage   80.19%   80.35%   +0.15%     
==========================================
  Files         406      406              
  Lines       14040    14040              
  Branches     4367     4347      -20     
==========================================
+ Hits        11260    11282      +22     
+ Misses       2613     2592      -21     
+ Partials      167      166       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind filling out the body of the PR?

I'm only seeing around 60% coverage, we're looking for ideally 100%, but minimum 80%.

@soumyaraju
Copy link
Contributor Author

@alisonjoseph increased coverage upto 80%, can you re check now?

@soumyaraju
Copy link
Contributor Author

@ariellalgilmore could you help me approve this PR and merge the changes. TIA

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Oct 25, 2024
Merged via the queue into carbon-design-system:main with commit 114c71e Oct 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants