Slider should not have interactions on hover when disabled #17771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for v11-carbon-web-components failed.
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17771 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 406 406
Lines 14019 14019
Branches 4356 4384 +28
=======================================
Hits 11154 11154
- Misses 2699 2700 +1
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. |
annawen1
approved these changes
Oct 16, 2024
kennylam
approved these changes
Oct 16, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
❌ Deploy Preview for v11-carbon-web-components failed. Why did it fail? →
|
Merged
via the queue into
carbon-design-system:main
with commit Oct 16, 2024
d5ae548
23 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17743
Fixed style when the Slider is disabled
Testing / Reviewing