fix(skeleton): adjust to work with any text-align property #17737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17737 +/- ##
=======================================
Coverage 79.29% 79.29%
=======================================
Files 406 406
Lines 14023 14023
Branches 4386 4390 +4
=======================================
Hits 11120 11120
Misses 2737 2737
Partials 166 166 ☔ View full report in Codecov by Sentry. |
ariellalgilmore
approved these changes
Oct 14, 2024
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Oct 14, 2024
98b7c28
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17236
Fix so that animation starts in the correct place regardless of text-align set.
Changelog
New
Testing / Reviewing
Nothing should have changed with any skeleton text stories. To test you can set the text-align either locally or in dev console to right and/or center and it should display the same.