-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filterable multiselect readonly state implemented #17662
fix: filterable multiselect readonly state implemented #17662
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor changes only.
packages/react/src/components/MultiSelect/FilterableMultiSelect.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/FilterableMultiSelect.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/FilterableMultiSelect.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17662 +/- ##
==========================================
- Coverage 79.72% 79.70% -0.02%
==========================================
Files 406 406
Lines 14012 14030 +18
Branches 4333 4364 +31
==========================================
+ Hits 11171 11183 +12
- Misses 2676 2681 +5
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Guru for the changes, Sorry one minor change again. Otherwise it looks good to me.
packages/react/src/components/MultiSelect/FilterableMultiSelect.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes Guru, Looks Good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
@laurenmrice could you do a review as well? Just want to be sure we didn't miss anything design-wise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @laurenmrice , I have added the functionality to not have any interaction during the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks, @Gururajj77 ! One last thing I noticed for the Filterable Multiselect is if you hover on the number in the tag in the read-only state, a disabled mouse cursor appears. The mouse cursor should just be the arrow, like how it appears when you hover on the x icon in the tag. I also see the number 2 in the tag looks like it has a highlighted background color behind it which it should not have.
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Have created an issue, #17820 to keep track for the hover issue separately |
7115f33
…-system#17662) * fix: filterable multiselect readonly state implemented * fix: reviewed changes added * fix: resovled pr review comments * feat: added readonly state for listboxselection * fix: removed conditional class on readonly matching disabled --------- Co-authored-by: Preeti Bansal <[email protected]>
Hey there! v11.69.0 was just released that references this issue/PR. |
…-system#17662) * fix: filterable multiselect readonly state implemented * fix: reviewed changes added * fix: resovled pr review comments * feat: added readonly state for listboxselection * fix: removed conditional class on readonly matching disabled --------- Co-authored-by: Preeti Bansal <[email protected]>
Closes #17587
read only state for filterable multiselect is implemented
Changelog
New
readOnly
propreadOnlyEventHandlers
method to handle events during thereadOnly
state.Changed
Testing / Reviewing
readOnly
prop and see if it works as expected.