-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement unique dynamic id generation for FileUploader component #17651
fix: implement unique dynamic id generation for FileUploader component #17651
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I am working on to resolve the unit test failures for FileUploader component .. I will fix the issue and push the changes by tomorrow
|
I will fix the above as well and push the updates to the PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17651 +/- ##
==========================================
+ Coverage 78.96% 79.00% +0.03%
==========================================
Files 408 408
Lines 14020 14008 -12
Branches 4381 4319 -62
==========================================
- Hits 11071 11067 -4
+ Misses 2782 2775 -7
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome change! Thanks!
261d33c
carbon-design-system#17651) * fix: implement unique dynamic id generation for FileUploader component * test(FileUploader): fix failing tests and update snapshot
Closes #17556
[{{short description}}](fix: implement unique dynamic id generation for FileUploader component)
useId
internal react hookChanged
src/components/FileUploader/FileUploader.tsx
Testing / Reviewing
yarn storybook
and confirmed that the FileUploader component now generates a unique id and it is being used in the component.