Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage for TimePicker #17639

Merged

Conversation

somya-05
Copy link
Contributor

@somya-05 somya-05 commented Oct 2, 2024

Closes #17497

Increase test coverage for TimePicker component.

Changelog

Changed

  • Increased test coverage to be above 80%

Testing / Reviewing

Check code coverage and make sure the test cases make sense

@somya-05 somya-05 requested a review from a team as a code owner October 2, 2024 19:38
Copy link
Contributor

github-actions bot commented Oct 2, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@somya-05
Copy link
Contributor Author

somya-05 commented Oct 2, 2024

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 673204f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66fda11b8e073d000835b260
😎 Deploy Preview https://deploy-preview-17639--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 673204f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66fda11b0434c600080492d9
😎 Deploy Preview https://deploy-preview-17639--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4d5d0c4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6703fd302109e600085bbb01
😎 Deploy Preview https://deploy-preview-17639--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d5d0c4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6703fd30185d4500088499fc
😎 Deploy Preview https://deploy-preview-17639--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@somya-05
Copy link
Contributor Author

somya-05 commented Oct 4, 2024

@kennylam @alisonjoseph please review the following changes

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.12%. Comparing base (99debcc) to head (4d5d0c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17639      +/-   ##
==========================================
+ Coverage   77.07%   77.12%   +0.04%     
==========================================
  Files         409      409              
  Lines       14021    14021              
  Branches     4327     4307      -20     
==========================================
+ Hits        10807    10814       +7     
+ Misses       3043     3037       -6     
+ Partials      171      170       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage at 83.78% now for TimePicker 👍
Screenshot 2024-10-07 at 1 30 04 PM

@somya-05
Copy link
Contributor Author

@kennylam please review the changes made

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Oct 17, 2024
Merged via the queue into carbon-design-system:main with commit 4312ae4 Oct 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase TimePicker unit test coverage
3 participants