Added typescript types to fluid combobox and its skeleton state #17563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17563 +/- ##
==========================================
- Coverage 77.13% 77.13% -0.01%
==========================================
Files 409 409
Lines 14024 14025 +1
Branches 4355 4307 -48
==========================================
Hits 10818 10818
- Misses 3035 3037 +2
+ Partials 171 170 -1 ☔ View full report in Codecov by Sentry. |
alisonjoseph
approved these changes
Sep 25, 2024
tay1orjones
reviewed
Oct 7, 2024
tay1orjones
reviewed
Oct 7, 2024
| @@ -105,7 +218,7 @@ FluidComboBox.propTypes = { | |||
| * `onChange` is a utility for this controlled component to communicate to a | |||
| * consuming component what kind of internal state changes are occurring. | |||
| */ | |||
| onChange: PropTypes.func, | |||
| onChange: PropTypes.func.isRequired, | |||
There was a problem hiding this comment.
I think this is a good idea. While this is technically a breaking change, this should've been required from the beginning because it's required in ComboBox and there is no default provided in this component.
tay1orjones
approved these changes
Oct 7, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 8, 2024
72617dd
22 of 23 checks passed
|
Hey there! v11.68.0 was just released that references this issue/PR. |
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
…on-design-system#17563) * fix: renamed js files to tsx for fluid combobox components * fix: added typescript types to fluid combobox * fix: snapshots * Update packages/react/src/components/FluidComboBox/FluidComboBox.tsx --------- Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: Alison Joseph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17367
Added typescript types to fluid combobox and its skeleton state
Changelog
Changed
Testing / Reviewing
Fluid Combobox and its skeleton state should work as intended.