fix: a11y modal heading issue

[riddhybansal]

Closes #17397

Maintain hierarchical order for the Heading levels :
Recommended to present the Modal Main heading in H2.

Changelog

Changed

• Modal and composed modal heading to h2

Testing / Reviewing

Modal and composed modal heading should be in h2

[netlify]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	1684282
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/6703ec395f12d40008b5d03e
😎 Deploy Preview	https://deploy-preview-17447--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for v11-carbon-react ready!

Name	Link
🔨 Latest commit	1684282
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/6703ec39615f850008fdc956
😎 Deploy Preview	https://deploy-preview-17447--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (e8c7672) to head (1684282).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17447   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files         409      409           
  Lines       14021    14021           
  Branches     4355     4307   -48     
=======================================
  Hits        10807    10807           
- Misses       3043     3044    +1     
+ Partials      171      170    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kennylam]

I'm wondering if this is actually required since the current component structure looks correct. There is no content following the first h2, which would make having another h2 immediately following it confusing to screen reader users. Maybe we could run this by Ragu to confirm?

[riddhybansal]

I'm wondering if this is actually required since the current component structure looks correct. There is no content following the first h2, which would make having another h2 immediately following it confusing to screen reader users. Maybe we could run this by Ragu to confirm?

I had the same concerns. Raghu told the product team to have this heirarchy in modal. Check here carbon-design-system/ibm-products#6019 . So raised the PR , not sure its required or not.

[kennylam]

Ah ok. I'll reach out to Ragu to discuss during the next QA meeeting.

[alisonjoseph]

@riddhybansal whats the status on this one?

[riddhybansal]

@riddhybansal whats the status on this one?

Heya @alisonjoseph I think @kennylam had a word with Raghu and this fix is required , so I think you can review it !! @kennylam can you confirm this ?

[kennylam]

Whoops, sorry for forgetting to update. Yes, spoke to Ragu about this and he said that either way is not really an issue.