fix: playGround story issue in NumberInput #17389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
2nikhiltom
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17389 +/- ##
=======================================
Coverage 76.82% 76.82%
=======================================
Files 408 408
Lines 13966 13966
Branches 4336 4336
=======================================
Hits 10730 10730
- Misses 3062 3063 +1
+ Partials 174 173 -1 ☔ View full report in Codecov by Sentry. |
riddhybansal
approved these changes
Sep 12, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 12, 2024
fdb31d9
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17164
This PR fixes the Playground story for NumberInput where the screen freezes and website crashes when
steppers(+/-) are clicked rapidlyPlayground story was throwing "allocation size overflow" error.
I suspect it was because of Complex props structure leading to JSON serialization problem
Changelog
Simplified Playground story with internal state management.
Moved props to Playground.args and Playground.argTypes
Testing / Reviewing
Open deploy preview and go to NumberInput - Playground story
click on steppers , verify that no errors are seen in console, and that website do not freeze/crash
verify that all props in playground works as expected