-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript types to fluid date picker and its skeleton state and fluid datepicker input #17385
Add typescript types to fluid date picker and its skeleton state and fluid datepicker input #17385
Conversation
Hey there @tay1orjones @Gururajj77 there is not any props defined for FluidDatePickerInput so what should be the type for this since no interface! |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
We can convert the file to |
3bb9e56
to
2952677
Compare
packages/react/src/components/FluidDatePickerInput/FluidDatePickerInput.tsx
Outdated
Show resolved
Hide resolved
@Gururajj77 do we need to explicitly specify that FluidDatePickerInput inherits DatePickerInputProps? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17385 +/- ##
=======================================
Coverage 76.92% 76.93%
=======================================
Files 408 408
Lines 13979 13980 +1
Branches 4339 4291 -48
=======================================
+ Hits 10754 10755 +1
Misses 3052 3052
Partials 173 173 ☔ View full report in Codecov by Sentry. |
aed133c
to
0c40f27
Compare
d644a8e
Hey there! v11.68.0 was just released that references this issue/PR. |
Closes #17366
Closes #17365
Added typescript types to fluid date picker and its skeleton state and fluid datepicker input
Changelog
Changed
Testing / Reviewing
FluidDatePickerInput, FluidDatePicker and its skeleton should work as intended.