Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typescript types to fluid combobox and its skeleton state #17384

Conversation

riddhybansal
Copy link
Contributor

Closes #17367

Added typescript types to fluid combobox and its skeleton state

Changelog

Changed

  • Added typescript types to fluid combobox and its skeleton state and converted index.js to index.tsx

Testing / Reviewing

Fluid Combobox and its skeleton state should work as intended.

@riddhybansal riddhybansal requested a review from a team as a code owner September 7, 2024 15:51
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 57115a1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66dc769cbedcb000080288c3
😎 Deploy Preview https://deploy-preview-17384--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a36d4fc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e814f6ff5b8f00089f1514
😎 Deploy Preview https://deploy-preview-17384--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riddhybansal riddhybansal self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add typescript types to FluidComboBox and its skeleton state
1 participant